Conversation
|
I like it ! It is a useful change. |
|
Could you refactor of Enum declaration to not break API compatibility: enum ModbusRTUTxEnableMode: bool {
/**
* The TX enable pin should be high when transmitting
*/
TxEnableHigh = true,
/**
* The TX enable pin should be low when transmitting
*/
TxEnableLow = false
}; |
|
Hi, |
|
To add my 2ct... I do like the first solution <0141b93>, but there are always more ways to achieve the same. @lmartorella notice your ABI note v.s. API compatibility request. These libraries are source level, so ABI compatibility is never needed |
Hello,
It is probably better to introduce an enum-based value for the current
txEnableDirect, to have a more self-explaining API, not requiring to look at the documentation to understand what really 'direct' mean in logic terms (e.g. from an electronic point of view, usually levels are negated, so 'direct' can be quite confusing here).What do you think about it?
Thx! L